Movatterモバイル変換

Skip to content

project-error/npwdPublic

NotificationsYou must be signed in to change notification settings
Fork279
Star373

feat(apps/phone): when creating a conversation, redirect to it if exists#1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

GiroudMathias wants to merge3 commits intoproject-error:master

base:master

Choose a base branch

fromGiroudMathias:master

Open

feat(apps/phone): when creating a conversation, redirect to it if exists#1066

GiroudMathias wants to merge3 commits intoproject-error:masterfromGiroudMathias:master

Conversation

@GiroudMathias

Copy link

GiroudMathias commentedAug 30, 2023•
edited
Loading

Pull Request Description

Somes changes and optimisations:

When creating a conversation, redirect to it if exists
Message's search in name and number

Pull Request Checklist:

Have you followed the guidelines in our Contributing document and Code of Conduct?
Have you checked to ensure there aren't other openPull Requests for the same update/change?
Have you built and tested NPWD in-game after the relevant change?

GiroudMathias added3 commits

August 30, 2023 22:51

@GiroudMathias

feat(apps/phone): when creating a conversation, redirect to it if exists

a6932a2

@GiroudMathias

fix: (apps/phone): Message's search in name and number

c15490f

@GiroudMathias

Merge branch 'master' into master

4105857

GiroudMathias

GiroudMathias commented

View reviewed changes

Copy link

Author

GiroudMathias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

On message, search user with number or contact name

itschip

itschip requested changes

View reviewed changes

apps/game/server/messages/messages.service.ts

		returnresp({
		status:'error',
		errorMsg:'MESSAGES.FEEDBACK.MESSAGE_CONVERSATION_DUPLICATE',
		data:{id:awaitthis.messagesDB.getConversationId(conversationList)}

Copy link

Member

itschipSep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please follow the pattern and call async function outside of theresp function

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@GiroudMathias

@itschip

[8]ページ先頭

©2009-2025 Movatter.jp