Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork279
Add support for give contact details#1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
BackSH00TER wants to merge1 commit intoproject-error:masterChoose a base branch fromBackSH00TER:give-contact-details
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
itschip requested changesJul 23, 2023
| import{ContactEvents}from'@typings/contact'; | ||
| import{RegisterNuiProxy}from'./cl_utils'; | ||
| constQBCore=global.exports['qb-core'].GetCoreObject(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As this is supposed to be as standalone as possible, we cannot use any third party library. We have these exports for external use only.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for giving contact details to other nearby players.
It will get the closest player and will open their phone onto the fill new contact screen with the name and number prefilled. The user then just has to save it.
To use this, users would be expected to update their radial menu to use the
'npwd:GiveContactDetailsevent.Example w/ qb-radialmenu
{id='givenum',title='Give Contact Details',icon='address-book',type='client',event='npwd:GiveContactDetails',shouldClose=true},If one already exists it will show the already populated contact card and the user can update it from there.
Example:
https://clipchamp.com/watch/9zspIfzTHbG
Pull Request Checklist: