- Notifications
You must be signed in to change notification settings - Fork229
Upgrading ruby and jekyll versions#3557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ZoeLeBlanc wants to merge15 commits intogh-pagesChoose a base branch fromupgrade-ruby-jekyll
base:gh-pages
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Ok so I've had to add in this logic to the bundle file to ensure that GitHub build.yml workflow works: bundle lock --add-platform x86_64-linuxbundle lock --add-platform arm64-darwin-24bundle lock --add-platform x86_64-darwin-20bundle lock --add-platform x64-mingw32 This gives us the following
I've also had to add in logic for pulling out htmlproofer errors. To do it you run:
Will be working with@anisa-hawes this month to fix these |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A much needed upgrade for Ruby and Jekyll versions so that it can run on newer Macbooks. Also upgrading our build.yml to use the official htmlproofer now that we have upgraded everything. This is part of the tasks for#3497
Checklist
Closes #ISSUENUMBERto your summary above