- Notifications
You must be signed in to change notification settings - Fork204
Make options hookable#321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
BernhardBaumrock wants to merge1 commit intoprocesswire:devChoose a base branch frombaumrock:make-options-hookable
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey@ryancramerdesign I'm developing a new module with RockMigrations. To create an options field the migration looks like this:
The problem is that I can not TRANSLATE option labels in this migration file for several reasons. This is not specific to options fields, but on all other fields I was able to translate labes notes and descriptions like this:
Unfortunately the field renders options with their original titles:
This missing hook has been a challenge for others (and myself) in the past:https://processwire.com/talk/topic/20321-add-custom-options-to-inputfieldselect-via-a-hook/
If there is a way to modify options of an options field already please let me know!
Otherwise thx for considering this PR :)