Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32
fix: Add jsx-runtime to aliases#171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
JoviDeCroock approved these changesOct 20, 2025
marvinhagemeister approved these changesOct 20, 2025
5ee464e intomain 1 check passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing this at work, Vite won't chase open-ended aliases (like
react->preact/compat, which can becomepreact/compat/client,preact/compat/server,preact/compat/jsx-runtime, etc) when optimizing ahead of time, choosing to instead defer that to detected usage during runtime (which is completely reasonable, IMO). Cacheless starts therefore see Vite refresh the page upon first load when it discovers & optimizes "react/jsx-runtime" which is a bit slower.Can make the argument that all
/compat/*entries should be listed here accordingly, though I'm not sure any of the other entries are likely to be used.cc@maybebot, in a few weeks we'll get to delete a single line of config