Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32
refactor: Switch tovite-prerender-plugin#153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
2f7a44b to3e0bc9aComparepackage.json Outdated
| "dev:preview":"vite preview demo", | ||
| "build":"rimraf dist && tsc && tsc -p tsconfig.cjs.json && node tools/postbuild.mjs", | ||
| "test":"node --testtest", | ||
| "test":"rimraf demo/node_modules &&node --test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We create a temp dir innode_modules (node_modules/<@preact/preset-vite|vite-prerender-plugin>/headless-prerender/...) to allow users to use external, non-bundlednode_modules whilst prerendering, but that screws with module resolution a tad. The demo will try to pull from that, but given it's just a holding place rather than an actual, installed module, that won't work.
Side effect of being monorepo-ish here.
| // Head API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All of this can be tested upstream
66b9069 intomainUh oh!
There was an error while loading.Please reload this page.
Moved it into the Preact org just the other day (preactjs/vite-prerender-plugin) as I wanted to keep an agnostic package for users to install, but syncing back & forth with this repo was a bit rough. It also is complex enough to warrant a bigger test suite, something which probably shouldn't be added here.
So, this PR switches over to consume it, rather than have an internal copy. Should be easier to maintain in the future hopefully.