Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: Regex to sets#398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rschristian wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromrefactor/regex-to-sets
Open

Conversation

@rschristian
Copy link
Member

Might be marginally faster? Probably easier to maintain at the very least -- easier to tell what properties are being replaced and which aren't.

I did this by comparing against Preact's types, mostly, with a few corrections needed for the SVG types.

@changeset-bot
Copy link

⚠️ No Changeset found

Latest commit:c12a3b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

HTML_LOWER_CASE,
HTML_ENUMERATED,
SVG_CAMEL_CASE,
SVG_KEBAB_CASE,
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Renamed for consistency.

HTML_LOWER_CASE is converting camel-cased names to lower-cased, thereforeSVG_CAMEL_CASE stands out as it's converting camel-cased names to kebab-cased.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rschristian
[8]ページ先頭
©2009-2025 Movatter.jp