Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork97
Remove all default exports (major)#185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
marvinhagemeister wants to merge2 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Mixing both default and named exports has no clearly defined behaviourand can easily lead to unexpected results. Some tools use a combination of"default" + "__esModule" property and others ignore named exportscompletely if both are found. Those issues are difficult to debug when multiple tools areused together.This change makes some code redundant by not having to patch a hand crafted exportsobject for commonjs environments.
ac04e79 to45c2938CompareJoviDeCroock approved these changesMar 10, 2021
Couldn't we provide only a default export? None of the other exported methods were widely used. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Mixing both default and named exports has no clearly defined behaviour and can easily lead to unexpected results. Some tools use a combination of
default+__esModuleproperty and others ignore named exports completely if both are found. Those issues are difficult to debug when multiple tools are used together.This change makes some code redundant by not having to patch a hand crafted exports object for commonjs environments.