Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork97
[experiment] ropes perf & dedicated SSR codepath#135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
developit wants to merge3 commits intomainChoose a base branch fromssr-performance
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Update: boo, I botched the benchmark and this is actually slower than master.
I've been sitting on this one for a little bit, and finally got the time to hack it out.Here's the changes:
No longer reuses renderToString() as an internal method for recursion.
This un-leaks the current private arguments, and enforces monomorphic recursive calls.
Use a "WIP String" reference.
This probably looks weird at first, but it's a JS engine trick. V8 has 11 different String representations, and one of the most highly optimized is called a "rope" (other engines have similar representations). Ropes are "virtual" Strings that are made up of tiny single string pieces - all of those
p.s += 'x'bits. They work a lot like a Buffer, which means they're extremely fast to build up.In addition to appending String segments to a rope being cheap, there's also a performance benefit to dropping the return value of our recursive function. Instead of the engine having to constantly copy strings returned from
renderToString(), there is only a single shared reference to the same string. This works really well in our current renderer because we always render depth-first and "top to bottom", so we're always able to append to the end of the WIP string.Dropping
prettyand other optionsThese are obviously super useful options and we want to have them around - they power a bunch of Preact addons. However, they're almost exclusively used by
preact-render-to-string/jsx, and that's already shipped as its own entry module. I'm proposing we turnimport "preact-render-to-string"into a single-purpose "render my app to HTML", and then usepreact-render-to-string/advancedor something along those lines as a path forward for all of the configurability bits. Or we could just leave it called/jsxand the name will just be slightly wrong from some use-cases.