- Notifications
You must be signed in to change notification settings - Fork90
fix: Filter defaults not working as intended#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 76 kB ℹ️View Unchanged
|
JoviDeCroock approved these changesFeb 14, 2025
bac7b04 intomaster 2 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Re:preactjs/preact#4652 (comment)
14f22a1 bumped the default pattern from the JS script, but not in the action config, ergo, it was entirely ignored as the action always provided an input here.
compressed-size-action/src/index.js
Line 45 in6fa0e7c
Alternatively, we could drop the fallbacks from the JS script & move them into the action config. However, I imagine the option this PR takes is preferable for testing purposes as we don't have to copy the values from the YML file into our test config.