NotificationsYou must be signed in to change notification settings
Fork22
Star162

Commit939aa7e

Karina Litskevich

committed

[PGPRO-14916] Update create_foreignscan_path() and create_foreign_upper_path() calls.

Caused by 9e9931d2 (postgres)"Re-allow FDWs and custom scan providers to replace joins with pseudoconstant quals."This is a fix from9dd4c1e (vops), which fixes vops to work with version 17.This fix is improved to take into account that vops should keep working withversions 16-. Also add some cosmetic changes in comments.Tags: vops

1 parent50e2b13 commit939aa7eCopy full SHA for 939aa7e

File tree

1 file changed

+14

-5

lines changed

vops_fdw.c

1 file changed

+14

-5

lines changed

`‎vops_fdw.c‎`

Lines changed: 14 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -440,9 +440,12 @@ postgresGetForeignPaths(PlannerInfo *root,`
`440`	`440`	`fpinfo->rows,`
`441`	`441`	`fpinfo->startup_cost,`
`442`	`442`	`fpinfo->total_cost,`
`443`		`-NIL,/* no pathkeys */`
	`443`	`+NIL,/* no pathkeys */`
`444`	`444`	`NULL,/* no outer rel either */`
`445`	`445`	`NULL,/* no extra plan */`
	`446`	`+#ifPG_VERSION_NUM>=170000`
	`447`	`+NIL,/* no fdw_restrictinfo list */`
	`448`	`+#endif`
`446`	`449`	`NIL);/* no fdw_private list */`
`447`	`450`	`add_path(baserel, (Path*)path);`
`448`	`451`	`}`
`@@ -1411,8 +1414,11 @@ add_foreign_grouping_paths(PlannerInfo root, RelOptInfo input_rel,`
`1411`	`1414`	`startup_cost,`
`1412`	`1415`	`total_cost,`
`1413`	`1416`	`NIL,/* no pathkeys */`
`1414`		`-NULL,`
`1415`		`-NIL);/* no fdw_private */`
	`1417`	`+NULL,/* no extra plan */`
	`1418`	`+#ifPG_VERSION_NUM>=170000`
	`1419`	`+NIL,/* no fdw_restrictinfo list */`
	`1420`	`+#endif`
	`1421`	`+NIL);/* no fdw_private list */`
`1416`	`1422`	`#else`
`1417`	`1423`	`grouppath=create_foreignscan_path(root,`
`1418`	`1424`	`grouped_rel,`
`@@ -1422,8 +1428,11 @@ add_foreign_grouping_paths(PlannerInfo root, RelOptInfo input_rel,`
`1422`	`1428`	`total_cost,`
`1423`	`1429`	`NIL,/* no pathkeys */`
`1424`	`1430`	`grouped_rel->lateral_relids,`
`1425`		`-NULL,`
`1426`		`-NIL);/* no fdw_private */`
	`1431`	`+NULL,/* no extra plan */`
	`1432`	`+#ifPG_VERSION_NUM>=170000`
	`1433`	`+NIL,/* no fdw_restrictinfo list */`
	`1434`	`+#endif`
	`1435`	`+NIL);/* no fdw_private list */`
`1427`	`1436`	`#endif`
`1428`	`1437`
`1429`	`1438`	`/* Add generated path into grouped_rel by add_path(). */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit939aa7e

File tree

1 file changed

1 file changed

`‎vops_fdw.c‎`

0 commit comments