Commit4766f93

authored

Merge pull request#120 from postgrespro/fix-already-used-port-startup-error

Fix error 'Is another postmaster already running on port XXX'

2 parents4c70b80 +fba3bd3 commit4766f93Copy full SHA for 4766f93

File tree

+32

-8

lines changed

+32

-8

lines changed

Lines changed: 24 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -726,14 +726,30 @@ def start(self, params=[], wait=True):`
`726`	`726`	`"start"`
`727`	`727`	`]+params# yapf: disable`
`728`	`728`
`729`		`-try:`
`730`		`-exit_status,out,error=execute_utility(_params,self.utils_log_file,verbose=True)`
`731`		`-iferrorand'does not exist'inerror:`
`732`		`-raiseException`
`733`		`-exceptExceptionase:`
`734`		`-msg='Cannot start node'`
`735`		`-files=self._collect_special_files()`
`736`		`-raise_from(StartNodeException(msg,files),e)`
	`729`	`+startup_retries=5`
	`730`	`+whileTrue:`
	`731`	`+try:`
	`732`	`+exit_status,out,error=execute_utility(_params,self.utils_log_file,verbose=True)`
	`733`	`+iferrorand'does not exist'inerror:`
	`734`	`+raiseException`
	`735`	`+exceptExceptionase:`
	`736`	`+files=self._collect_special_files()`
	`737`	`+ifany(len(file)>1and'Is another postmaster already '`
	`738`	`+'running on port'infile[1].decode()for`
	`739`	`+fileinfiles):`
	`740`	`+print("Detected an issue with connecting to port {0}. "`
	`741`	`+"Trying another port after a 5-second sleep...".format(self.port))`
	`742`	`+self.port=reserve_port()`
	`743`	`+options= {}`
	`744`	`+options['port']=str(self.port)`
	`745`	`+self.set_auto_conf(options)`
	`746`	`+startup_retries-=1`
	`747`	`+time.sleep(5)`
	`748`	`+continue`
	`749`	`+`
	`750`	`+msg='Cannot start node'`
	`751`	`+raise_from(StartNodeException(msg,files),e)`
	`752`	`+break`
`737`	`753`	`self._maybe_start_logger()`
`738`	`754`	`self.is_started=True`
`739`	`755`	`returnself`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1033,6 +1033,14 @@ def test_parse_pg_version(self):`
`1033`	`1033`	`# Macos`
`1034`	`1034`	`assertparse_pg_version("postgres (PostgreSQL) 14.9 (Homebrew)")=="14.9"`
`1035`	`1035`
	`1036`	`+deftest_the_same_port(self):`
	`1037`	`+withget_new_node()asnode:`
	`1038`	`+node.init().start()`
	`1039`	`+`
	`1040`	`+withget_new_node()asnode2:`
	`1041`	`+node2.port=node.port`
	`1042`	`+node2.init().start()`
	`1043`	`+`
`1036`	`1044`
`1037`	`1045`	`if__name__=='__main__':`
`1038`	`1046`	`ifos.environ.get('ALT_CONFIG'):`

Comments

(0)