Commit3a1d08b

authored

RemoteOperations::path_exists is updated (#206)

- command is passed through list- we process all the result codes of test

1 parente1a5bb4 commit3a1d08bCopy full SHA for 3a1d08b

File tree

+40

-12

lines changed

+40

-12

lines changed

Lines changed: 24 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -247,8 +247,30 @@ def listdir(self, path):`
`247`	`247`	`returnresult.splitlines()`
`248`	`248`
`249`	`249`	`defpath_exists(self,path):`
`250`		`-result=self.exec_command("test -e {}; echo $?".format(path),encoding=get_default_encoding())`
`251`		`-returnint(result.strip())==0`
	`250`	`+command= ["test","-e",path]`
	`251`	`+`
	`252`	`+exit_status,output,error=self.exec_command(cmd=command,encoding=get_default_encoding(),ignore_errors=True,verbose=True)`
	`253`	`+`
	`254`	`+asserttype(output)==str# noqa: E721`
	`255`	`+asserttype(error)==str# noqa: E721`
	`256`	`+`
	`257`	`+ifexit_status==0:`
	`258`	`+returnTrue`
	`259`	`+`
	`260`	`+ifexit_status==1:`
	`261`	`+returnFalse`
	`262`	`+`
	`263`	`+errMsg="Test operation returns an unknown result code: {0}. Path is [{1}].".format(`
	`264`	`+exit_status,`
	`265`	`+path)`
	`266`	`+`
	`267`	`+RaiseError.CommandExecutionError(`
	`268`	`+cmd=command,`
	`269`	`+exit_code=exit_status,`
	`270`	`+msg_arg=errMsg,`
	`271`	`+error=error,`
	`272`	`+out=output`
	`273`	`+ )`
`252`	`274`
`253`	`275`	`@property`
`254`	`276`	`defpathsep(self):`

Lines changed: 16 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -130,23 +130,29 @@ def test_listdir(self):`
`130`	`130`
`131`	`131`	`assertisinstance(files,list)`
`132`	`132`
`133`		`-deftest_path_exists_true(self):`
	`133`	`+deftest_path_exists_true__directory(self):`
`134`	`134`	`"""`
`135`		`- Test path_exists for an existingpath.`
	`135`	`+ Test path_exists for an existingdirectory.`
`136`	`136`	`"""`
`137`		`-path="/etc"`
`138`		`-response=self.operations.path_exists(path)`
	`137`	`+assertself.operations.path_exists("/etc")isTrue`
`139`	`138`
`140`		`-assertresponseisTrue`
	`139`	`+deftest_path_exists_true__file(self):`
	`140`	`+"""`
	`141`	`+ Test path_exists for an existing file.`
	`142`	`+ """`
	`143`	`+assertself.operations.path_exists(__file__)isTrue`
`141`	`144`
`142`		`-deftest_path_exists_false(self):`
	`145`	`+deftest_path_exists_false__directory(self):`
`143`	`146`	`"""`
`144`		`- Test path_exists for a non-existingpath.`
	`147`	`+ Test path_exists for a non-existingdirectory.`
`145`	`148`	`"""`
`146`		`-path="/nonexistent_path"`
`147`		`-response=self.operations.path_exists(path)`
	`149`	`+assertself.operations.path_exists("/nonexistent_path")isFalse`
`148`	`150`
`149`		`-assertresponseisFalse`
	`151`	`+deftest_path_exists_false__file(self):`
	`152`	`+"""`
	`153`	`+ Test path_exists for a non-existing file.`
	`154`	`+ """`
	`155`	`+assertself.operations.path_exists("/etc/nonexistent_path.txt")isFalse`
`150`	`156`
`151`	`157`	`deftest_write_text_file(self):`
`152`	`158`	`"""`

Comments

(0)