Commit27c40d2

committed

PortManager::find_free_port is updated

Asserts are added: - ports must be the "set" - exclude_ports must be iterableDo not convert exclude_ports into "set" [optimization?]

1 parentab7de69 commit27c40d2Copy full SHA for 27c40d2

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,11 @@ def find_free_port(self, ports: Optional[Set[int]] = None, exclude_ports: Option`
`26`	`26`	`ifportsisNone:`
`27`	`27`	`ports=set(range(1024,65535))`
`28`	`28`
	`29`	`+asserttype(ports)==set`
	`30`	`+`
`29`	`31`	`ifexclude_portsisnotNone:`
`30`		`-ports.difference_update(set(exclude_ports))`
	`32`	`+assertisinstance(exclude_ports,Iterable)`
	`33`	`+ports.difference_update(exclude_ports)`
`31`	`34`
`32`	`35`	`sampled_ports=random.sample(tuple(ports),min(len(ports),100))`
`33`	`36`

Comments

(0)