Commit8627439

Arseny Kositsyn

committed

[PGPRO-11599] Code review. Part 4.

Tags: rum

1 parentabb40fa commit8627439Copy full SHA for 8627439

File tree

+14

-7

lines changed

+14

-7

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,9 @@ This module is available under the [license](LICENSE) similar to`
`45`	`45`
`46`	`46`	`Before building and installingrum, you should ensure following are installed:`
`47`	`47`
`48`		`-* PostgreSQL version is 9.6+.`
	`48`	`+* PostgreSQL version is 12+.`
	`49`	`+`
	`50`	+* PostgreSQL 9.6 - 11 (but you need to transfer the`src/backend/nodes/tidbitmap.c` of the required version to the`contrib/rum/src/tidbitmap/tidbitmapXX.c` and include it to`contrib/rum/src/rumtidbitmap.c`)
`49`	`51`
`50`	`52`	`Typical installation procedure may look like this:`
`51`	`53`

Lines changed: 11 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,18 +14,23 @@`
`14`	`14`
`15`	`15`	`#include"rumtidbitmap.h"`
`16`	`16`
	`17`	`+/*`
	`18`	`+ * NOTE: For compatibility with PostgreSQL versions less than 12,`
	`19`	`+ * you need to transfer the src/backend/nodes/tidbitmap.c of the`
	`20`	`+ * required version to the RUM and include it here.`
	`21`	`+ */`
`17`	`22`	`#ifPG_VERSION_NUM >=170000`
`18`		`-#include"tidbitmap17.c"`
	`23`	`+#include"tidbitmap/tidbitmap17.c"`
`19`	`24`	`#elifPG_VERSION_NUM >=160000`
`20`		`-#include"tidbitmap16.c"`
	`25`	`+#include"tidbitmap/tidbitmap16.c"`
`21`	`26`	`#elifPG_VERSION_NUM >=150000`
`22`		`-#include"tidbitmap15.c"`
	`27`	`+#include"tidbitmap/tidbitmap15.c"`
`23`	`28`	`#elifPG_VERSION_NUM >=140000`
`24`		`-#include"tidbitmap14.c"`
	`29`	`+#include"tidbitmap/tidbitmap14.c"`
`25`	`30`	`#elifPG_VERSION_NUM >=130000`
`26`		`-#include"tidbitmap13.c"`
	`31`	`+#include"tidbitmap/tidbitmap13.c"`
`27`	`32`	`#elifPG_VERSION_NUM >=120000`
`28`		`-#include"tidbitmap12.c"`
	`33`	`+#include"tidbitmap/tidbitmap12.c"`
`29`	`34`	`#endif`
`30`	`35`
`31`	`36`	`RumTIDBitmap*`