Commit2bddc22

committed

remove from tail of filelist on modern postgres

Modern postgres actually uses array as List implementation.Therefore, removing element from head is quite expensive.

1 parent78baca7 commit2bddc22Copy full SHA for 2bddc22

File tree

-0

lines changed

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -402,12 +402,21 @@ ptrack_filelist_getnext(PtScanCtx * ctx)`
`402`	`402`	`if (list_length(ctx->filelist)==0)`
`403`	`403`	`return-1;`
`404`	`404`
	`405`	`+#ifdefforeach_current_index`
	`406`	`+/* Get first file from the head */`
	`407`	`+cell=list_tail(ctx->filelist);`
	`408`	`+pfl= (PtrackFileList_i*)lfirst(cell);`
	`409`	`+`
	`410`	`+/* Remove this file from the list */`
	`411`	`+ctx->filelist=list_delete_last(ctx->filelist);`
	`412`	`+#else`
`405`	`413`	`/* Get first file from the head */`
`406`	`414`	`cell=list_head(ctx->filelist);`
`407`	`415`	`pfl= (PtrackFileList_i*)lfirst(cell);`
`408`	`416`
`409`	`417`	`/* Remove this file from the list */`
`410`	`418`	`ctx->filelist=list_delete_first(ctx->filelist);`
	`419`	`+#endif`
`411`	`420`
`412`	`421`	`if (pfl->segno>0)`
`413`	`422`	`{`

Comments

(0)