NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbd1cfde

committed

Fix RBM_ZERO_AND_LOCK mode to not acquire lock on local buffers.

Commit81c4508 introduced a new RBM_ZERO_AND_LOCK mode to ReadBuffer, whichtakes a lock on the buffer before zeroing it. However, you cannot take alock on a local buffer, and you got a segfault instead. The version of thatpatch committed to master included a check for !isLocalBuf, and thereforedidn't crash, but oddly I missed that in the back-patched versions. Thispatch adds that check to the back-branches too.RBM_ZERO_AND_LOCK mode is only used during WAL replay, and in hash indexes.WAL replay only deals with shared buffers, so the only way to trigger thebug is with a temporary hash index.Reported by Artem Ignatyev, analysis by Tom Lane.

1 parentb93c8ea commitbd1cfdeCopy full SHA for bd1cfde

File tree

1 file changed

-1

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-1

lines changed

`‎src/backend/storage/buffer/bufmgr.c‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,8 @@ ReadBuffer_common(SMgrRelation smgr, bool isLocalBuf, ForkNumber forkNum,`
`483`	`483`	`* (Note that we cannot use LockBuffer() of LockBufferForCleanup() here,`
`484`	`484`	`* because they assert that the buffer is already valid.)`
`485`	`485`	`*/`
`486`		`-if (mode==RBM_ZERO_AND_LOCK\|\|mode==RBM_ZERO_AND_CLEANUP_LOCK)`
	`486`	`+if ((mode==RBM_ZERO_AND_LOCK\|\|mode==RBM_ZERO_AND_CLEANUP_LOCK)&&`
	`487`	`+!isLocalBuf)`
`487`	`488`	`LWLockAcquire(bufHdr->content_lock,LW_EXCLUSIVE);`
`488`	`489`
`489`	`490`	`if (isLocalBuf)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbd1cfde

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c‎`

0 commit comments