NotificationsYou must be signed in to change notification settings
Fork15
Star24

Fix doc deploy#144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vitcpp merged 2 commits intopostgrespro:masterfromvitcpp:fix-doc-deploy

Oct 17, 2025

Merged

Fix doc deploy#144

vitcpp merged 2 commits intopostgrespro:masterfromvitcpp:fix-doc-deploy

Oct 17, 2025

Conversation

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm all for addingworkflow_dispatch:, but why are you removing thepush: branches: - "master" lines?

Copy link

Contributor

esabolOct 17, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Never mind. I get it. We want the docs to only update when there's a new release. May I suggest the following instead?

on:  release:    types: [published]  workflow_dispatch:

That will trigger automatically only when a new release is published. In the context of a GitHub Actions workflow, "published" means that a release has been finalized and made visible to the public, or specifically, marked as a non-draft and non-prerelease version. This is distinct from simply saving a draft.

Reference:https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#release

Set doc deployment on release publication

c77b3cc

The docs should be deployed when a new release is publishing. There isno point to deploy the docs every time when the master branch isupdated. The proposed change sets automatic doc deployment only on anew release publication or manually.