Commiteb531bc

Artur Zakirov

committed

WAL delete fixes

1 parentb188a8a commiteb531bcCopy full SHA for eb531bc

File tree

-12

lines changed

-12

lines changed

Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -92,9 +92,9 @@ backup_data_page(pgFile file, const XLogRecPtr lsn,`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`/*`
`95`		`-* If an invalid data page was found, fallback to simple copy to ensure`
`96`		`-* all pages in the file don't have BackupPageHeader.`
`97`		`-*/`
	`95`	`+* If an invalid data page was found, fallback to simple copy to ensure`
	`96`	`+* all pages in the file don't have BackupPageHeader.`
	`97`	`+*/`
`98`	`98`	`if (!parse_page(&page,&page_lsn))`
`99`	`99`	`{`
`100`	`100`	`inti;`
`@@ -226,9 +226,6 @@ backup_data_file(const char from_root, const char to_root,`
`226`	`226`	`to_path,strerror(errno_tmp));`
`227`	`227`	`}`
`228`	`228`
`229`		`-/* confirm server version */`
`230`		`-check_server_version();`
`231`		`-`
`232`	`229`	`/*`
`233`	`230`	`* Read each page, verify checksum and write it to backup.`
`234`	`231`	`* If page map is not empty we scan only these blocks, otherwise`
`@@ -244,10 +241,7 @@ backup_data_file(const char from_root, const char to_root,`
`244`	`241`	`datapagemap_iterator_t*iter;`
`245`	`242`	`iter=datapagemap_iterate(&file->pagemap);`
`246`	`243`	`while (datapagemap_next(iter,&blknum))`
`247`		`-{`
`248`		`-elog(WARNING,"Iter bitmap. blknum %u, nblocks %u",blknum,nblocks);`
`249`	`244`	`backup_data_page(file,lsn,blknum,nblocks,in,out,&crc);`
`250`		`-}`
`251`	`245`
`252`	`246`	`pg_free(iter);`
`253`	`247`	`/*`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ do_deletewal(time_t backup_id, bool strict)`
`139`	`139`	`parray_walk(backup_list,pgBackupFree);`
`140`	`140`	`parray_free(backup_list);`
`141`	`141`
`142`		`-delete_walfiles(oldest_lsn,oldest_tli,false);`
	`142`	`+delete_walfiles(oldest_lsn,oldest_tli,true);`
`143`	`143`
`144`	`144`	`return0;`
`145`	`145`	`}`
`@@ -349,10 +349,11 @@ delete_walfiles(XLogRecPtr oldest_lsn, TimeLineID oldest_tli, bool delete_all)`
`349`	`349`	`* they were originally written, in case this worries you.`
`350`	`350`	`*/`
`351`	`351`	`if (IsXLogFileName(arcde->d_name)\|\|`
`352`		`-IsPartialXLogFileName(arcde->d_name))`
	`352`	`+IsPartialXLogFileName(arcde->d_name)\|\|`
	`353`	`+IsBackupHistoryFileName(arcde->d_name))`
`353`	`354`	`{`
`354`	`355`	`if (XLogRecPtrIsInvalid(oldest_lsn)\|\|`
`355`		`-strcmp(arcde->d_name+8,oldestSegmentNeeded+8)<0)`
	`356`	`+strncmp(arcde->d_name+8,oldestSegmentNeeded+8,16)<0)`
`356`	`357`	`{`
`357`	`358`	`/*`
`358`	`359`	`* Use the original file name again now, including any`

Comments

(0)