Commitacc8edc

and

Ivan Lazarev

authored

minor hotfix for OptionTest.test_help_6, OptionTest.test_version_2 and tests/Readme.md FAQ (#494)

Co-authored-by: Ivan Lazarev <i.lazarev@postgrespro.ru>

1 parente72feb6 commitacc8edcCopy full SHA for acc8edc

File tree

+32

-2

lines changed

+32

-2

lines changed

Lines changed: 30 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-[see wiki](https://confluence.postgrespro.ru/display/DEV/pg_probackup)`
	`1`	`+****[see wiki](https://confluence.postgrespro.ru/display/DEV/pg_probackup)`
`2`	`2`
`3`	`3`	```
`4`	`4`	`Note: For now these tests work on Linux and "kinda" work on Windows`
`@@ -50,3 +50,32 @@ Usage:`
`50`	`50`	`export PG_CONFIG=/path/to/pg_config`
`51`	`51`	`python -m unittest [-v] tests[.specific_module][.class.test]`
`52`	`52`	```
	`53`	`+`
	`54`	`+###Troubleshooting FAQ`
	`55`	`+`
	`56`	`+####python test failures`
	`57`	`+1. Test failure reason like`
	`58`	+```
	`59`	`+testgres.exceptions.QueryException ERROR: could not open extension control file "/home/avaness/postgres/postgres.build/share/extension/amcheck.control": No such file or directory`
	`60`	+```
	`61`	`+`
	`62`	+Solution: you have no`<postgres_src_root>/contrib/` extensions installed
	`63`	`+`
	`64`	+```commandline
	`65`	`+cd <postgres_src_root>`
	`66`	`+make world install`
	`67`	+```
	`68`	`+`
	`69`	`+2. Test failure`
	`70`	`+`
	`71`	+```
	`72`	`+FAIL: test_help_6 (tests.option.OptionTest)`
	`73`	+```
	`74`	`+`
	`75`	+Solution: you didn't configure postgres build with`--enable-nls`
	`76`	`+`
	`77`	+```commandline
	`78`	`+cd <postgres_src_root>`
	`79`	`+make distclean`
	`80`	`+<your-./configure-cmdline> --enable-nls`
	`81`	+```

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,7 @@ pg_probackup - утилита для управления резервным к`
`178`	`178`	`[--remote-proto] [--remote-host]`
`179`	`179`	`[--remote-port] [--remote-path] [--remote-user]`
`180`	`180`	`[--ssh-options]`
	`181`	`+ [--dry-run]`
`181`	`182`	`[--help]`
`182`	`183`
`183`	`184`	`Подробнее читайте на сайте <https://github.com/postgrespro/pg_probackup>.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ def test_version_2(self):`
`24`	`24`	`"""help options"""`
`25`	`25`	`withopen(os.path.join(self.dir_path,"expected/option_version.out"),"rb")asversion_out:`
`26`	`26`	`self.assertIn(`
`27`		`-version_out.read().decode("utf-8"),`
	`27`	`+version_out.read().decode("utf-8").strip(),`
`28`	`28`	`self.run_pb(["--version"])`
`29`	`29`	`)`
`30`	`30`

Comments

(0)