NotificationsYou must be signed in to change notification settings
Fork69
Star589

Commit4e84256

committed

Raise notice 'insufficient privileges', fix pg_constraint_fn inclusion.

1 parent0137d19 commit4e84256Copy full SHA for 4e84256

File tree

3 files changed

+13

-5

lines changed

3 files changed

+13

-5

lines changed

`‎expected/pathman_permissions.out‎`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,9 @@ BEGIN`
`17`	`17`	`SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);`
`18`	`18`	`EXCEPTION`
`19`	`19`	`WHEN insufficient_privilege THEN`
	`20`	`+ RAISE NOTICE 'Insufficient priviliges';`
`20`	`21`	`END$$;`
	`22`	`+NOTICE: Insufficient priviliges`
`21`	`23`	`/* Grant SELECT to user2 */`
`22`	`24`	`SET ROLE user1;`
`23`	`25`	`GRANT SELECT ON permissions.user1_table TO user2;`
`@@ -28,7 +30,9 @@ BEGIN`
`28`	`30`	`SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);`
`29`	`31`	`EXCEPTION`
`30`	`32`	`WHEN insufficient_privilege THEN`
	`33`	`+ RAISE NOTICE 'Insufficient priviliges';`
`31`	`34`	`END$$;`
	`35`	`+NOTICE: Insufficient priviliges`
`32`	`36`	`/* Should be ok */`
`33`	`37`	`SET ROLE user1;`
`34`	`38`	`SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);`
`@@ -71,7 +75,9 @@ BEGIN`
`71`	`75`	`INSERT INTO permissions.user1_table (id, a) VALUES (35, 0);`
`72`	`76`	`EXCEPTION`
`73`	`77`	`WHEN insufficient_privilege THEN`
	`78`	`+ RAISE NOTICE 'Insufficient priviliges';`
`74`	`79`	`END$$;`
	`80`	`+NOTICE: Insufficient priviliges`
`75`	`81`	`/* No rights to create partitions (need INSERT privilege) */`
`76`	`82`	`SET ROLE user2;`
`77`	`83`	`SELECT prepend_range_partition('permissions.user1_table');`
`@@ -133,7 +139,9 @@ BEGIN`
`133`	`139`	`SELECT drop_range_partition('permissions.user1_table_4');`
`134`	`140`	`EXCEPTION`
`135`	`141`	`WHEN insufficient_privilege THEN`
	`142`	`+ RAISE NOTICE 'Insufficient priviliges';`
`136`	`143`	`END$$;`
	`144`	`+NOTICE: Insufficient priviliges`
`137`	`145`	`/* Disable automatic partition creation */`
`138`	`146`	`SET ROLE user1;`
`139`	`147`	`SELECT set_auto('permissions.user1_table', false);`

`‎sql/pathman_permissions.sql‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ BEGIN`
`23`	`23`	`SELECT create_range_partitions('permissions.user1_table','id',1,10,2);`
`24`	`24`	`EXCEPTION`
`25`	`25`	`WHEN insufficient_privilege THEN`
	`26`	`+ RAISE NOTICE'Insufficient priviliges';`
`26`	`27`	`END$$;`
`27`	`28`
`28`	`29`	`/* Grant SELECT to user2*/`
`@@ -36,6 +37,7 @@ BEGIN`
`36`	`37`	`SELECT create_range_partitions('permissions.user1_table','id',1,10,2);`
`37`	`38`	`EXCEPTION`
`38`	`39`	`WHEN insufficient_privilege THEN`
	`40`	`+ RAISE NOTICE'Insufficient priviliges';`
`39`	`41`	`END$$;`
`40`	`42`
`41`	`43`	`/* Should be ok*/`
`@@ -64,6 +66,7 @@ BEGIN`
`64`	`66`	`INSERT INTOpermissions.user1_table (id, a)VALUES (35,0);`
`65`	`67`	`EXCEPTION`
`66`	`68`	`WHEN insufficient_privilege THEN`
	`69`	`+ RAISE NOTICE'Insufficient priviliges';`
`67`	`70`	`END$$;`
`68`	`71`
`69`	`72`	`/* No rights to create partitions (need INSERT privilege)*/`
`@@ -101,6 +104,7 @@ BEGIN`
`101`	`104`	`SELECT drop_range_partition('permissions.user1_table_4');`
`102`	`105`	`EXCEPTION`
`103`	`106`	`WHEN insufficient_privilege THEN`
	`107`	`+ RAISE NOTICE'Insufficient priviliges';`
`104`	`108`	`END$$;`
`105`	`109`
`106`	`110`	`/* Disable automatic partition creation*/`

`‎src/relation_info.c‎`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,6 @@`
`20`	`20`	`#include"catalog/catalog.h"`
`21`	`21`	`#include"catalog/indexing.h"`
`22`	`22`	`#include"catalog/pg_constraint.h"`
`23`		`-#ifPG_VERSION_NUM<110000&&PG_VERSION_NUM >=90600`
`24`		`-#include"catalog/pg_constraint_fn.h"`
`25`		`-#endif`
`26`	`23`	`#include"catalog/pg_inherits.h"`
`27`	`24`	`#include"catalog/pg_type.h"`
`28`	`25`	`#include"miscadmin.h"`
`@@ -47,8 +44,7 @@`
`47`	`44`	`#ifPG_VERSION_NUM<90600`
`48`	`45`	`#include"optimizer/planmain.h"`
`49`	`46`	`#endif`
`50`		`-`
`51`		`-#ifPG_VERSION_NUM >=90600&&PG_VERSION_NUM<11000`
	`47`	`+#ifPG_VERSION_NUM<110000&&PG_VERSION_NUM >=90600`
`52`	`48`	`#include"catalog/pg_constraint_fn.h"`
`53`	`49`	`#endif`
`54`	`50`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4e84256

File tree

3 files changed

3 files changed

`‎expected/pathman_permissions.out‎`

`‎sql/pathman_permissions.sql‎`

`‎src/relation_info.c‎`

0 commit comments