NotificationsYou must be signed in to change notification settings
Fork69
Star589

Commit079797e

committed

Purge potentially created bounds cache entries if build_pathman_relation_info failed.

Otherwise they might contain obsolete data, e.g. - create range partitioned table T with a couple of partitions - make pathman forget about it - create another table P inherited from previously partitioned one, but with no pathman constraints - attempt to add_to_pathman_config T as range partitioned table it will fail as P has no constraint, but might register other partitions in bounds cache - now add_to_pathman_config T as hash partitioned table will fail in attempt to use this cache (part_idx not initialized)

1 parente251d2a commit079797eCopy full SHA for 079797e

File tree

1 file changed

+27

-1

lines changed

src
- relation_info.c

1 file changed

+27

-1

lines changed

`‎src/relation_info.c‎`

Lines changed: 27 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -408,7 +408,7 @@ build_pathman_relation_info(Oid relid, Datum *values)`
`408`	`408`	`prel->fresh= true;`
`409`	`409`	`prel->mcxt=prel_mcxt;`
`410`	`410`
`411`		`-/* Memory leak protection */`
	`411`	`+/* Memory leakand cacheprotection */`
`412`	`412`	`PG_TRY();`
`413`	`413`	`{`
`414`	`414`	`MemoryContextold_mcxt;`
`@@ -496,6 +496,32 @@ build_pathman_relation_info(Oid relid, Datum *values)`
`496`	`496`	`}`
`497`	`497`	`PG_CATCH();`
`498`	`498`	`{`
	`499`	`+/*`
	`500`	`+ * If we managed to create some children but failed later, bounds`
	`501`	`+ * cache now might have obsolete data for something that probably is`
	`502`	`+ * not a partitioned table at all. Remove it.`
	`503`	`+ */`
	`504`	`+if (prel->children!=NULL)`
	`505`	`+{`
	`506`	`+uint32i;`
	`507`	`+`
	`508`	`+for (i=0;i<PrelChildrenCount(prel);i++)`
	`509`	`+{`
	`510`	`+Oidchild;`
	`511`	`+`
	`512`	`+/*`
	`513`	`+ * We rely on children and ranges array allocated with 0s, not`
	`514`	`+ * random data`
	`515`	`+ */`
	`516`	`+if (prel->parttype==PT_HASH)`
	`517`	`+child=prel->children[i];`
	`518`	`+elseif (prel->parttype==PT_RANGE)`
	`519`	`+child=prel->ranges[i].child_oid;`
	`520`	`+`
	`521`	`+forget_bounds_of_partition(child);`
	`522`	`+}`
	`523`	`+}`
	`524`	`+`
`499`	`525`	`/* Free this entry */`
`500`	`526`	`free_pathman_relation_info(prel);`
`501`	`527`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit079797e

File tree

1 file changed

1 file changed

`‎src/relation_info.c‎`

0 commit comments