NotificationsYou must be signed in to change notification settings
Fork49
Star707

Commit4eb6a98

Alexander Korotkov

committed

Fix text serialization for NOT operator. Parenthesis needed around NOT, not

around its operand.Reported by Pavan Deolasee.

1 parent509ca85 commit4eb6a98Copy full SHA for 4eb6a98

File tree

3 files changed

+13

-6

lines changed

3 files changed

+13

-6

lines changed

`‎expected/jsquery.out‎`

Lines changed: 11 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -376,13 +376,13 @@ select 'not < 1'::jsquery;`
`376`	`376`	`select 'not not < 1'::jsquery;`
`377`	`377`	`jsquery`
`378`	`378`	`-----------------`
`379`		`- NOT("not" < 1)`
	`379`	`+(NOT "not" < 1)`
`380`	`380`	`(1 row)`
`381`	`381`
`382`	`382`	`select 'not( not < 1)'::jsquery;`
`383`	`383`	`jsquery`
`384`	`384`	`-----------------`
`385`		`- NOT("not" < 1)`
	`385`	`+(NOT "not" < 1)`
`386`	`386`	`(1 row)`
`387`	`387`
`388`	`388`	`select 'not.x < 1'::jsquery;`
`@@ -397,6 +397,12 @@ select 'x.not < 1'::jsquery;`
`397`	`397`	`"x"."not" < 1`
`398`	`398`	`(1 row)`
`399`	`399`
	`400`	`+select 'a.%(not x > 0 and not (y < 0 or z = 0))'::jsquery;`
	`401`	`+ jsquery`
	`402`	`+-----------------------------------------------------`
	`403`	`+ "a".%((NOT "x" > 0) AND (NOT ("y" < 0 OR "z" = 0)))`
	`404`	`+(1 row)`
	`405`	`+`
`400`	`406`	`select 'is < 1'::jsquery;`
`401`	`407`	`jsquery`
`402`	`408`	`----------`
`@@ -412,13 +418,13 @@ select 'in < 1'::jsquery;`
`412`	`418`	`select 'not is < 1'::jsquery;`
`413`	`419`	`jsquery`
`414`	`420`	`----------------`
`415`		`- NOT("is" < 1)`
	`421`	`+(NOT "is" < 1)`
`416`	`422`	`(1 row)`
`417`	`423`
`418`	`424`	`select 'not in < 1'::jsquery;`
`419`	`425`	`jsquery`
`420`	`426`	`----------------`
`421`		`- NOT("in" < 1)`
	`427`	`+(NOT "in" < 1)`
`422`	`428`	`(1 row)`
`423`	`429`
`424`	`430`	`select 'in in (1,2)'::jsquery;`
`@@ -844,7 +850,7 @@ select 'asd.# = 3'::jsquery & 'zzz = true' \| 'xxx.# = zero';`
`844`	`850`	`select !'asd.# = 3'::jsquery & 'zzz = true' \| !'xxx.# = zero';`
`845`	`851`	`?column?`
`846`	`852`	`------------------------------------------------------------------`
`847`		`- ((NOT("asd".# = 3) AND "zzz" = true) OR NOT("xxx".# = "zero"))`
	`853`	`+ (((NOT "asd".# = 3) AND "zzz" = true) OR(NOT "xxx".# = "zero"))`
`848`	`854`	`(1 row)`
`849`	`855`
`850`	`856`	`select '{"x":[0,1,1,2]}'::jsonb @@ 'x @> [1,0]'::jsquery;`

`‎jsquery_io.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ printJsQueryItem(StringInfo buf, JsQueryItem *v, bool inKey, bool printBracketes`
`315`	`315`	`appendStringInfoChar(buf,')');`
`316`	`316`	`break;`
`317`	`317`	`casejqiNot:`
`318`		`-appendBinaryStringInfo(buf,"NOT(",5);`
	`318`	`+appendBinaryStringInfo(buf,"(NOT ",5);`
`319`	`319`	`jsqGetArg(v,&elem);`
`320`	`320`	`printJsQueryItem(buf,&elem, false, true);`
`321`	`321`	`appendStringInfoChar(buf,')');`

`‎sql/jsquery.sql‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ select 'not not < 1'::jsquery;`
`75`	`75`	`select'not( not < 1)'::jsquery;`
`76`	`76`	`select'not.x < 1'::jsquery;`
`77`	`77`	`select'x.not < 1'::jsquery;`
	`78`	`+select'a.%(not x > 0 and not (y < 0 or z = 0))'::jsquery;`
`78`	`79`
`79`	`80`	`select'is < 1'::jsquery;`
`80`	`81`	`select'in < 1'::jsquery;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4eb6a98

File tree

3 files changed

3 files changed

`‎expected/jsquery.out‎`

`‎jsquery_io.c‎`

`‎sql/jsquery.sql‎`

0 commit comments