Commitd0afdc1

committed

Disallow AQO to write into the ML-tables if can be detected that

the query must be read-only (by the flag XactReadOnly).

1 parentce7188c commitd0afdc1Copy full SHA for d0afdc1

File tree

+16

-0

lines changed

+16

-0

lines changed

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,10 @@ update_query(int qhash, int fhash,`
`125`	`125`	`ScanKeyDatakey;`
`126`	`126`	`SnapshotDatasnap;`
`127`	`127`
	`128`	`+/* Couldn't allow to write if xact must be read-only. */`
	`129`	`+if (XactReadOnly)`
	`130`	`+return false;`
	`131`	`+`
`128`	`132`	`reloid=RelnameGetRelid("aqo_queries_query_hash_idx");`
`129`	`133`	`if (!OidIsValid(reloid))`
`130`	`134`	`{`
`@@ -225,6 +229,10 @@ add_query_text(int qhash)`
`225`	`229`	`Oidreloid;`
`226`	`230`	`char*text_str;`
`227`	`231`
	`232`	`+/* Couldn't allow to write if xact must be read-only. */`
	`233`	`+if (XactReadOnly)`
	`234`	`+return false;`
	`235`	`+`
`228`	`236`	`reloid=RelnameGetRelid("aqo_query_texts_query_hash_idx");`
`229`	`237`	`if (!OidIsValid(reloid))`
`230`	`238`	`{`
`@@ -386,6 +394,10 @@ update_fss(int fhash, int fsshash, int nrows, int ncols,`
`386`	`394`	`ScanKeyDatakey[2];`
`387`	`395`	`boolresult= true;`
`388`	`396`
	`397`	`+/* Couldn't allow to write if xact must be read-only. */`
	`398`	`+if (XactReadOnly)`
	`399`	`+return false;`
	`400`	`+`
`389`	`401`	`reloid=RelnameGetRelid("aqo_fss_access_idx");`
`390`	`402`	`if (!OidIsValid(reloid))`
`391`	`403`	`{`
`@@ -575,6 +587,10 @@ update_aqo_stat(int qhash, QueryStat *stat)`
`575`	`587`	`IndexScanDescscan;`
`576`	`588`	`ScanKeyDatakey;`
`577`	`589`
	`590`	`+/* Couldn't allow to write if xact must be read-only. */`
	`591`	`+if (XactReadOnly)`
	`592`	`+return;`
	`593`	`+`
`578`	`594`	`reloid=RelnameGetRelid("aqo_query_stat_idx");`
`579`	`595`	`if (!OidIsValid(reloid))`
`580`	`596`	`{`

Comments

(0)