NotificationsYou must be signed in to change notification settings
Fork5.2k
Star19k

Commitfce7da1

committed

Handle cancel requests with PID 0 gracefully

If the client sent a query cancel request with backend PID 0, ittripped an assertion. With assertions disabled, you got this in thelog instead: LOG: invalid cancel request with PID 0 LOG: wrong key in cancel request for process 0Query cancellations don't even require authentication, so we bettertolerate bogus requests. Fix by turning the assertion into a regularruntime check.Spotted while testing libpq behavior with a modified server thatdidn't send BackendKeyData to the client.Backpatch-through: 18

1 parent8e5e3ff commitfce7da1Copy full SHA for fce7da1

File tree

1 file changed

-1

lines changed

src/backend/storage/ipc
- procsignal.c

1 file changed

-1

lines changed

`‎src/backend/storage/ipc/procsignal.c‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,11 @@ procsignal_sigusr1_handler(SIGNAL_ARGS)`
`728`	`728`	`void`
`729`	`729`	`SendCancelRequest(intbackendPID,constuint8*cancel_key,intcancel_key_len)`
`730`	`730`	`{`
`731`		`-Assert(backendPID!=0);`
	`731`	`+if (backendPID==0)`
	`732`	`+{`
	`733`	`+ereport(LOG, (errmsg("invalid cancel request with PID 0")));`
	`734`	`+return;`
	`735`	`+}`
`732`	`736`
`733`	`737`	`/*`
`734`	`738`	`* See if we have a matching backend. Reading the pss_pid and`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfce7da1

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/procsignal.c‎`

0 commit comments