Commitbaf45ba

petere

and

nmisch

committed

Put back intra-grant-inplace.spec test coverage

Commitd31bbfb lost some test coverage, because the situationbeing tested, a concurrent DROP, cannot happen anymore. Put the testcoverage back with a bit of a trick, by deleting directly from thecatalog table.Co-authored-by: Noah Misch <noah@leadboat.com>Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>Discussion:https://www.postgresql.org/message-id/flat/bf72b82c-124d-4efa-a484-bb928e9494e4@eisentraut.org

1 parent118601a commitbaf45baCopy full SHA for baf45ba

File tree

2 files changed

-3

lines changed

src/test/isolation
- expected
  - intra-grant-inplace.out
- specs
  - intra-grant-inplace.spec

2 files changed

-3

lines changed

`‎src/test/isolation/expected/intra-grant-inplace.out‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ step revoke4: <... completed>`
`226`	`226`	`starting permutation: b1 drop1 b3 sfu3 revoke4 c1 r3`
`227`	`227`	`step b1: BEGIN;`
`228`	`228`	`step drop1:`
`229`		`-DROP TABLEintra_grant_inplace;`
	`229`	`+DELETE FROM pg_class WHERE relname = 'intra_grant_inplace';`
`230`	`230`
`231`	`231`	`step b3: BEGIN ISOLATION LEVEL READ COMMITTED;`
`232`	`232`	`step sfu3:`
`@@ -248,6 +248,6 @@ relhasindex`
`248`	`248`	`-----------`
`249`	`249`	`(0 rows)`
`250`	`250`
`251`		`-s4: WARNING: got:relation "intra_grant_inplace" does not exist`
	`251`	`+s4: WARNING: got:cache lookup failed for relation REDACTED`
`252`	`252`	`step revoke4: <... completed>`
`253`	`253`	`step r3: ROLLBACK;`

`‎src/test/isolation/specs/intra-grant-inplace.spec‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ step grant1{`
`20`	`20`	`GRANTSELECTONintra_grant_inplaceTOPUBLIC;`
`21`	`21`	`}`
`22`	`22`	`stepdrop1{`
`23`		`-DROPTABLEintra_grant_inplace;`
	`23`	`+DELETEFROMpg_classWHERErelname='intra_grant_inplace';`
`24`	`24`	`}`
`25`	`25`	`stepc1{COMMIT;}`
`26`	`26`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbaf45ba

File tree

2 files changed

2 files changed

`‎src/test/isolation/expected/intra-grant-inplace.out‎`

`‎src/test/isolation/specs/intra-grant-inplace.spec‎`

0 commit comments