- Notifications
You must be signed in to change notification settings - Fork5.2k
Commit992a18f
committed
Fix incorrect lack of Datum conversion in _int_matchsel()
The code used return (Selectivity) 0.0;where PG_RETURN_FLOAT8(0.0);would be correct.On 64-bit systems, these are pretty much equivalent, but on 32-bitsystems, PG_RETURN_FLOAT8() correctly produces a pointer, but the oldwrong code would return a null pointer, possibly leading to a crashelsewhere.We think this code is actually not reachable because bqarr_in won'taccept an empty query, and there is no other function that willcreate query_int values. But better be safe and not let suchincorrect code lie around.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://www.postgresql.org/message-id/flat/8246d7ff-f4b7-4363-913e-827dadfeb145%40eisentraut.org1 parentbba6a6f commit992a18f
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
0 commit comments
Comments
(0)