NotificationsYou must be signed in to change notification settings
Fork5.2k
Star19k

Commit36026b0

committed

pg_dump: Fix object-type sort priority for large objects.

Commita45c78e moved large object metadata from SECTION_PRE_DATAto SECTION_DATA but neglected to move PRIO_LARGE_OBJECT indbObjectTypePriorities accordingly. While this hasn't produced anyknown live bugs, it causes problems for a proposed patch thatoptimizes upgrades with many large objects. Fixing the prioritymight also make the topological sort step marginally faster byreducing the number of ordering violations that have to be fixed.Reviewed-by: Nitin Motiani <nitinmotiani@google.com>Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/aBkQLSkx1zUJ-LwJ%40nathanDiscussion:https://postgr.es/m/aG_5DBCjdDX6KAoD%40nathanBackpatch-through: 17

1 parent99fd638 commit36026b0Copy full SHA for 36026b0

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump_sort.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump_sort.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,10 @@ enum dbObjectTypePriorities`
`76`	`76`	`PRIO_TABLE_ATTACH,`
`77`	`77`	`PRIO_DUMMY_TYPE,`
`78`	`78`	`PRIO_ATTRDEF,`
`79`		`-PRIO_LARGE_OBJECT,`
`80`	`79`	`PRIO_PRE_DATA_BOUNDARY,/* boundary! */`
`81`	`80`	`PRIO_TABLE_DATA,`
`82`	`81`	`PRIO_SEQUENCE_SET,`
	`82`	`+PRIO_LARGE_OBJECT,`
`83`	`83`	`PRIO_LARGE_OBJECT_DATA,`
`84`	`84`	`PRIO_STATISTICS_DATA_DATA,`
`85`	`85`	`PRIO_POST_DATA_BOUNDARY,/* boundary! */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit36026b0

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump_sort.c‎`

0 commit comments