NotificationsYou must be signed in to change notification settings
Fork5.2k
Star19k

Commit2d83d72

committed

jit: Fix accidentally-harmless type confusion

In2a0faed, which added JIT compilation support for expressions, Iaccidentally used sizeof(LLVMBasicBlockRef *) instead ofsizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. Thatturns out to have no real negative consequences due to LLVMBasicBlockRef beinga pointer itself (and thus having the same size). It still is wrong andconfusing, so fix it.Reported by coverity.Backpatch-through: 13

1 parentd115de9 commit2d83d72Copy full SHA for 2d83d72

File tree

1 file changed

-1

lines changed

src/backend/jit/llvm
- llvmjit_expr.c

1 file changed

-1

lines changed

`‎src/backend/jit/llvm/llvmjit_expr.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2505,7 +2505,7 @@ llvm_compile_expr(ExprState *state)`
`2505`	`2505`	`v_nullsp=l_ptr_const(nulls,l_ptr(TypeStorageBool));`
`2506`	`2506`
`2507`	`2507`	`/* create blocks for checking args */`
`2508`		`-b_checknulls=palloc(sizeof(LLVMBasicBlockRef)nargs);`
	`2508`	`+b_checknulls=palloc(sizeof(LLVMBasicBlockRef)*nargs);`
`2509`	`2509`	`for (intargno=0;argno<nargs;argno++)`
`2510`	`2510`	`{`
`2511`	`2511`	`b_checknulls[argno]=`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2d83d72

File tree

1 file changed

1 file changed

`‎src/backend/jit/llvm/llvmjit_expr.c‎`

0 commit comments