Commit20b8b5d

committed

Fix stale idle flag when IO workers exit.

Otherwise we could choose a worker that has exited and crash whiletrying to wake it up.Back-patch to 18.Reported-by: Tomas Vondra <tomas@vondra.me>Reported-by: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/t5aqjhkj6xdkido535pds7fk5z4finoxra4zypefjqnlieevbg%40357aaf6u525j

1 parentccacaf4 commit20b8b5dCopy full SHA for 20b8b5d

File tree

-0

lines changed

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,7 @@ pgaio_choose_idle_worker(void)`
`172`	`172`	`/* Find the lowest bit position, and clear it. */`
`173`	`173`	`worker=pg_rightmost_one_pos64(io_worker_control->idle_worker_mask);`
`174`	`174`	`io_worker_control->idle_worker_mask &= ~(UINT64_C(1) <<worker);`
	`175`	`+Assert(io_worker_control->workers[worker].in_use);`
`175`	`176`
`176`	`177`	`returnworker;`
`177`	`178`	`}`
`@@ -316,6 +317,7 @@ pgaio_worker_die(int code, Datum arg)`
`316`	`317`	`Assert(io_worker_control->workers[MyIoWorkerId].in_use);`
`317`	`318`	`Assert(io_worker_control->workers[MyIoWorkerId].latch==MyLatch);`
`318`	`319`
	`320`	`+io_worker_control->idle_worker_mask &= ~(UINT64_C(1) <<MyIoWorkerId);`
`319`	`321`	`io_worker_control->workers[MyIoWorkerId].in_use= false;`
`320`	`322`	`io_worker_control->workers[MyIoWorkerId].latch=NULL;`
`321`	`323`	`LWLockRelease(AioWorkerSubmissionQueueLock);`

Comments

(0)