- Notifications
You must be signed in to change notification settings - Fork2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
BorringSSL Fork#2342
base:poco-1.10.0
Are you sure you want to change the base?
BorringSSL Fork#2342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
1.9.0 has already been released, please send this pull to 1.9.1
Crypto/src/CipherKeyImpl.cpp Outdated
| case EVP_CIPH_CCM_MODE: | ||
| return MODE_CCM; | ||
| //Changed for port OpenSSL -> BoringSSL | ||
| #if defined(OPENSSL_IS_BORINGSSL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why this?
| throw NotImplementedException(); | ||
| #else | ||
| std::string friendlyName; | ||
| f(pCert) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I doubt this will compile
| #else | ||
| //Changed for port OpenSSL -> BoringSSL | ||
| #if defined(OPENSSL_IS_BORINGSSL) | ||
| dh->p = BN_bin2bn(dh1024_p, sizeof(dh1024_p), 0); | ||
| dh->g = BN_bin2bn(dh1024_g, sizeof(dh1024_g), 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no need to set dh->length here?
Please re-target pull request against poco-1.10.0 branch. |
@matejk not urgent, put on TODO list |
Those are changes necessary to build Poco Library with BoringSSL instead of OpenSSL.
I tested that it's works on MacOs.