Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add LensFlareEffect#695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
shotamatsuda wants to merge7 commits intopmndrs:dev
base:dev
Choose a base branch
Loading
fromshotamatsuda:feat/lens-flare-effect

Conversation

@shotamatsuda
Copy link

@shotamatsudashotamatsuda commentedMar 9, 2025
edited
Loading

Related issue:#581

Description

This PR adds a LensFlareEffect based onhttps://www.froyok.fr/blog/2021-09-ue4-custom-lens-flare/.

image

Limitations

  • Uses a simple bloom glare instead of a starburst shape.
  • Ghosts and halos are not configurable.
  • No anamorphic distortion.

Considerations

  • Luminance threshold and bloom overlap with existing effects and passes. Separating them would require two additional passes, but is a possible option.
  • The downsampling follows Sledgehammer Games’s method12, which differs from DownsamplingMaterial. I have yet to compare and determine which is better.
  • Ghosts could be made configurable, but it might require a bit complex parameter interface.

vanruesc and BorisKourt reacted with heart emoji
@shotamatsudashotamatsuda changed the titleFeat/lens flare effectAdd LensFlareEffectMar 9, 2025
@shotamatsudashotamatsuda changed the titleAdd LensFlareEffectfeat: add LensFlareEffectMar 9, 2025
@vanruesc
Copy link
Member

vanruesc commentedMar 9, 2025
edited
Loading

Thanks! I'll take a closer look at this when I have more time on my hands.

At a glance, it looks like this effect duplicates the bloom effect which is suboptimal from a maintenance perspective. If this effect doesn't require the bloom-related code, it should be removed.

It might also make sense to create a dedicatedLensFlarePass for theLensFlareFeaturesMaterial to implement lens-flare-specific configuration options in that pass. The pass would then be used instead of the internalShaderPass.

I'm also not sure about the duplicated luminance threshold and downsampling code. It would be better if the existing passes could be reused.

shotamatsuda reacted with thumbs up emoji

@shotamatsuda
Copy link
Author

Thanks for reviewing! I agree with your points and will work on those changes.

BorisKourt reacted with thumbs up emoji

@kitaedesigns
Copy link

Wow excited for this one, thanks@shotamatsuda for your work!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shotamatsuda@vanruesc@kitaedesigns

[8]ページ先頭

©2009-2025 Movatter.jp