Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork239
feat: add LensFlareEffect#695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vanruesc commentedMar 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks! I'll take a closer look at this when I have more time on my hands. At a glance, it looks like this effect duplicates the bloom effect which is suboptimal from a maintenance perspective. If this effect doesn't require the bloom-related code, it should be removed. It might also make sense to create a dedicated I'm also not sure about the duplicated luminance threshold and downsampling code. It would be better if the existing passes could be reused. |
shotamatsuda commentedMar 10, 2025
Thanks for reviewing! I agree with your points and will work on those changes. |
kitaedesigns commentedApr 1, 2025
Wow excited for this one, thanks@shotamatsuda for your work! |
Uh oh!
There was an error while loading.Please reload this page.
Related issue:#581
Description
This PR adds a LensFlareEffect based onhttps://www.froyok.fr/blog/2021-09-ue4-custom-lens-flare/.
Limitations
Considerations