Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Documentation conversion into Mkdocs#5384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:live-docs
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
a2787a03dced44bc32c86174b0e9badb19986f69f1c0237f676b36dd96af9f69525f6a80792d893867506d1e5c820c60efa07ea455cad0132e38a9ae45f54c73a829136ee5e957d923cca3738231b73cefae9563c2e20c70f9b3113f5ee9ff345aeff840f114a7873cb0cd2f9cd623aa98fab989ddde0f683643cefde20101da1c68d12a0566901164154910df9cc3a77d19bbbdd049bcbd983d95ea81831c8a2ff35c9faeef950ee3390983e5ee8ba943429569b6d76d2f32fdc0418a66208c6d116e278607d4a9a40907b215b3718470619da9b2d883c0d963882d07e8a63877e76af1d1620c2310f66a673e590fa35da1d89e17373e1bc6e300adc3a98b664b30da8f43c74e712a016aeb2231fadabed97052335144728beee0da4dc5476c8ea1bd6fc6304f0c61a566c835430e4855deca22b4c5cb40c3d202259a8e10fac1686cf3ff4ee82f488de444fb8319de7994893d74a371c6099ed0d19bd5d88da53c24f7d6a2d466ed077940ecc2b1f816001b36bd491fb5d9184fdae5b402d03fea587d91d2046a28d14ddc1e1a1b44e72d04d2be36f6bf0568db07569161db0a265548f17cb33362eba4b7b3f2801036e13ba7f1e16f34eca79bdb8064a52fa5a1c00108933be2464dddb53d9b8cc3b514bc8eed29e6b84abb898f38e69f468c6d1603120e6d8e18b266eea0e270fade001cb53e22fbb70fa6e7237aacd455db0a6320483251eb8fcfaf9bfb622af18ef612afe64dc403caa7802eb159079f7440654fde19ff8730eb6ed26ae2f80bae54f18a7a5122e1ac5263f03d079fe887396432492c8f030fea9b38edf2b1a3ae43db89b3dd487da393c28d17a305e674fe05438f5a4c3ef53b41e15a23af23812346a55b423c2db929fce7ca99833905a975f47ddcd6e107e992409127bdcbaea4d18bf9ea07b53e0fb9832File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Diff view
Diff view
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -8,7 +8,7 @@ then explains the technical aspects of preparing your contribution. | ||
| ## Code of Conduct | ||
| Please note that all contributos are required to abide by our Code of Conduct. | ||
| ## Different Ways to Contribute | ||
| @@ -19,7 +19,7 @@ it is important to understand the structure of the code and the repository. | ||
| - The [`plotly.graph_objects`](https://plotly.com/python/graph-objects/) module (usually imported as `go`) | ||
| is [generated from the plotly.js schema](https://plotly.com/python/figure-structure/), | ||
| so changes to be made in this package need to be contributed to [plotly.js](https://github.com/plotly/plotly.js) | ||
| or to the code generation system in `./bin/codegen/`. | ||
| Code generation creates traces and layout classes that have a direct correspondence to their JavaScript counterparts, | ||
| while higher-level methods that work on figures regardless of the current schema (e.g., `BaseFigure.for_each_trace`) | ||
| are defined in `plotly/basedatatypes.py`. | ||
| @@ -38,16 +38,17 @@ it is important to understand the structure of the code and the repository. | ||
| These are organized in subdirectories according to what they test: | ||
| see the "Setup" section below for more details. | ||
| - Documentation is found in `doc/`, and its structure is described in its README file. | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Could we update the readme to have the new doc build process. | ||
| The documentation is a great place to start contributing, | ||
| since you can add or modify examples without setting up a full environment. | ||
| Code and documentation are not the only way to contribute. | ||
| You can also help by: | ||
| - Reporting bugs at <https://github.com/plotly/plotly.py/issues>. | ||
| Please take a moment to see if your problem has already been reported, and if so, add a comment to the existing issue; | ||
| we will try to prioritize those that affect the most people | ||
| and that are accompanied by small, runnable examples. | ||
| - Submitting feature requests (also at <https://github.com/plotly/plotly.py/issues>). | ||
| Again, please add a comment to an existing issue if the feature you want has already been requested. | ||
| @@ -233,11 +234,11 @@ Once you have done that, | ||
| run the `updateplotlyjs` command: | ||
| ```bash | ||
| pythonbin/updatejs.py | ||
| ``` | ||
| This downloads new versions of `plot-schema.json` and `plotly.min.js` from the `plotly/plotly.js` GitHub repository | ||
| and places them in `resources` and `plotly/package_data` respectively. | ||
| It then regenerates all of the `graph_objs` classes based on the new schema. | ||
| ### Using a Development Branch of Plotly.js | ||
| @@ -246,7 +247,8 @@ If your development branch is in [the plotly.js repository](https://github.com/p | ||
| you can update to development versions of `plotly.js` with this command: | ||
| ```bash | ||
| # FIXME commands.py didn't provide --devrepo or --devbranch | ||
| python bin/updatejs.py --dev --devrepo reponame --devbranch branchname | ||
| ``` | ||
| This fetches the `plotly.js` in the CircleCI artifact of the branch `branchname` of the repo `reponame`. | ||
| @@ -269,5 +271,6 @@ You can then run the following command | ||
| *in your local plotly.py repository*: | ||
| ```bash | ||
| # FIXME: commands.py didn't provide --local | ||
| python bin/updatejs.py --dev --local /path/to/your/plotly.js/ | ||
| ``` | ||
Uh oh!
There was an error while loading.Please reload this page.