Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
refactor: Update script to generate schema JSON with 2 space indentation#7626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
draftlogs/7626_change.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not totally sure whether we need a draftlog for this, but I don't mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, I'll drop this one. It's not really necessary.
emilykl left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reasonable 👍
It does increase the file size from 3.6 to 4.2 MB. But if this file is used anywhere that the filesize actually matters, we should remove all whitespace anyway.
This reverts commit96e79bc.
f07f1c7 intomasterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Description
Update script to generate schema JSON with 2 space indentation.
Closes#7625.
Changes
Testing
npm run schemaNotes
TODO