Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: Update script to generate schema JSON with 2 space indentation#7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
camdecoster merged 5 commits intomasterfromcam/7625/update-schema-build-script
Nov 24, 2025

Conversation

@camdecoster
Copy link
Contributor

@camdecostercamdecoster commentedNov 12, 2025
edited
Loading

Description

Update script to generate schema JSON with 2 space indentation.

Closes#7625.

Changes

  • Update script
  • Update schema

Testing

  • Be on master
  • Opentest/plot-schema.json in a text editor
  • Note that the indentation is 1 space per level
  • Switch to this branch
  • Run the schema build script withnpm run schema
  • Open the same file
  • Note that the indentation is 2 spaces per level

Notes

  • The schema file has a huge diff, but it's all white space
  • You can turn off white space in the diff view with this option:
    image

TODO

  • Add draftlog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not totally sure whether we need a draftlog for this, but I don't mind

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, I'll drop this one. It's not really necessary.

Copy link
Contributor

@emilyklemilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reasonable 👍

It does increase the file size from 3.6 to 4.2 MB. But if this file is used anywhere that the filesize actually matters, we should remove all whitespace anyway.

@camdecostercamdecoster merged commitf07f1c7 intomasterNov 24, 2025
6 checks passed
@camdecostercamdecoster deleted the cam/7625/update-schema-build-script branchNovember 24, 2025 20:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@emilyklemilyklemilykl approved these changes

@alexshoealexshoeAwaiting requested review from alexshoe

Assignees

@camdecostercamdecoster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increase indenting in schema JSON file

3 participants

@camdecoster@emilykl

[8]ページ先頭

©2009-2025 Movatter.jp