Hello, I am new to this project and attempting to contribute my first PR.

Unfortunately, I am struggling to get the build to pass. Specifically, thepublish-dist-node-v22 step:
https://app.circleci.com/pipelines/github/plotly/plotly.js/12658/workflows/ae5271e7-9971-4db1-a713-b42f0625901f/jobs/282198

I tried runningnpm run schema and pushing the change here:
9463b3f

But still encountering the issue.

Any insight would be greatly appreciated. Thank you!

Edit: tagging a few recent commiters for visibility, thanks so much! (cc@camdecoster@alexshoe@emilykl)

Hi@degzhaus, thank you for working on this contribution!

As it stands currently, the devtools dashboard needs to be running in order fornpm run schema to work properly. So you should runnpm start and leave it running, and then in another terminal runnpm run schema. (@camdecoster is working on a PR to eliminate that step, see#7589)

You can also downloadplot-schema.json from the "Artifacts" tab in CircleCI and commit it.

Hi@degzhaus, thank you for working on this contribution!

As it stands currently, the devtools dashboard needs to be running in order fornpm run schema to work properly. So you should runnpm start and leave it running, and then in another terminal runnpm run schema. (@camdecoster is working on a PR to eliminate that step, see#7589)

You can also downloadplot-schema.json from the "Artifacts" tab in CircleCI and commit it.

Thank you so much,@emilykl! That was very helpful and unblocked me.

Unfortunately, I have been struggling with theno-gl-jasmine test in ci:
https://app.circleci.com/pipelines/github/plotly/plotly.js/12700/workflows/8b80de4d-1bad-455d-baef-72bc47c31042/jobs/283463

If you have any insight, I would greatly appreciate it. Thanks again!

Edit:@emilykl i figured it out! Pardon my flailing at last night. So exciting! I have a couple of tests to add and this will be ready for review.

Thanks again for your insights and help!

@degzhaus Great news, glad you're unblocked! Thank you for your work on this. Quiver is a plot type we've gotten a lot of requests for.

A few high-level comments on the API:

• This trace type is fairly distinct from existingscatter* trace types; let's go with the namequiver instead.

• The most similar already-existing trace type isthe 3dcone trace, so the attributes ofquiver should match the existing API ofcone as closely as possible for consistency. For example, rather than thescale property it should usesizemode andsizeref as the cone trace does. (Obviously, some attributes likez andw are not relevant in a 2d context).

• Any attributes for configuring the size/scale of the arrowhead should match thearrowhead config options for annotations

  • It's also notnecessary to include those options in a first version of this trace type, but any attributes thatare added should be consistent with what's already in the library

• There's a few other things I noticed in the attributes as well:

  • Thescaleratio attribute doesn't belong; the scale ratio between the axes should be a property of the axes themselves, not the trace. The axis scale ratio can already be configured using the existingaxis.scaleratio attribute.
  • It's unclear to me how theangle attribute interacts withu andv, sinceu andv are already sufficient to fully determine the arrow's angle. Theangle attribute should probably be removed.

@degzhaus Great news, glad you're unblocked! Thank you for your work on this. Quiver is a plot type we've gotten a lot of requests for.

A few high-level comments on the API:

• This trace type is fairly distinct from existingscatter* trace types; let's go with the namequiver instead.

• The most similar already-existing trace type isthe 3dcone trace, so the attributes ofquiver should match the existing API ofcone as closely as possible for consistency. For example, rather than thescale property it should usesizemode andsizeref as the cone trace does. (Obviously, some attributes likez andw are not relevant in a 2d context).

• Any attributes for configuring the size/scale of the arrowhead should match thearrowhead config options for annotations

  • It's also notnecessary to include those options in a first version of this trace type, but any attributes thatare added should be consistent with what's already in the library

• There's a few other things I noticed in the attributes as well:

  • Thescaleratio attribute doesn't belong; the scale ratio between the axes should be a property of the axes themselves, not the trace. The axis scale ratio can already be configured using the existingaxis.scaleratio attribute.
  • It's unclear to me how theangle attribute interacts withu andv, sinceu andv are already sufficient to fully determine the arrow's angle. Theangle attribute should probably be removed.

Amazing, thank you so much for taking a look and providing great guidance, Emily! Looking forward to spinning a cycle on this feedback.

@degzhaus One more comment — it would be great to include colorscale attributes inquiver so that arrows can be colored according to the magnitude of the vector. These attributes are added to the cone tracehere; something similar can be done for the quiver trace. And then obviously those attributes need to be referenced in the plotting code to assign the appropriate color.

Pardon the delay,@emilykl, i was finally able to make time to clean this up. I removed some of my recent comments/questions because they were noise around me understanding how to work with thetests/images, but i was able to figure it out.

Thanks again for all your help with this PR! Excited for next steps.

Hi@degzhaus ! I'm aiming to give this another review by the end of the week. Sorry for the delay in getting back to you — looking forward to it! Thanks for your work so far.

Thank you for this idea,@gpdf ! Added here:

• 9ff8120

That's great, thank you!

Perhaps for future readers' clarity of understanding,@degzhaus , you could edit the description at the top of the PR to say:

scatterquiverquiver

in the two places it appears, so that the as-merged plot type appears there.

Perhaps for future readers' clarity of understanding,@degzhaus , you could edit the description at the top of the PR to say:

scatterquiverquiver

in the two places it appears, so that the as-merged plot type appears there.

Great catch, thank you so much,@gpdf !

Updated per your recommendation, and did a little review/revision based on changes made during the review process as well.

Hi@degzhaus ! I'm aiming to give this another review by the end of the week. Sorry for the delay in getting back to you — looking forward to it! Thanks for your work so far.

Hey there,@emilykl, hope you're having a wonderful week!

I rebased, cleaned up some code, and added some tests here:
0252e03

Thanks again for everything!

I really appreciate all the effort in polishing, and very much look forward to using this.