Commit59f1536

committed

Improving tests for PlotlyViaCdnModule

1 parent04a1cd2 commit59f1536Copy full SHA for 59f1536

File tree

+21

-1

lines changed

+21

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* Update the version in package.json`
`4`	`4`	`* Update the version in projects/plotly/package.json`
`5`	`5`	`* Update the CHANGELOG.md`
`6`		-*`ng test --codeCoverage=true --progress=true --watch=false`
	`6`	+*`ng test --code-coverage=true --progress=true --watch=false`
`7`	`7`	*`cp README.md angular-plotly.png projects/plotly`
`8`	`8`	*`ng build plotly --configuration production`
`9`	`9`	*`git commit -am "<version>"`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,4 +33,24 @@ describe('PlotlyViaCDNModule', () => {`
`33`	`33`	`expect(fn).toThrowError(msg);`
`34`	`34`	`});`
`35`	`35`
	`36`	`+describe(".setPlotlyVersion",()=>{`
	`37`	`+it('should set Plotly version',()=>{`
	`38`	`+constversion="latest";`
	`39`	`+spyOn(PlotlyViaCDNModule,"loadViaCDN");`
	`40`	`+`
	`41`	`+PlotlyViaCDNModule.setPlotlyVersion(version);`
	`42`	`+`
	`43`	`+expect(PlotlyViaCDNModule.loadViaCDN).toHaveBeenCalled();`
	`44`	`+expect((PlotlyViaCDNModuleasany).plotlyVersion).toBe(version);`
	`45`	`+});`
	`46`	`+`
	`47`	`+it('should NOT set Plotly version',()=>{`
	`48`	`+constversion="invalid";`
	`49`	`+spyOn(PlotlyViaCDNModule,"loadViaCDN").and.callThrough();`
	`50`	`+`
	`51`	`+expect(()=>{`
	`52`	`+PlotlyViaCDNModule.setPlotlyVersion(version);`
	`53`	`+}).toThrowError("Invalid plotly version. Please set 'latest' or version number (i.e.: 1.4.3)");`
	`54`	`+});`
	`55`	`+});`
`36`	`56`	`});`

Comments

(0)