Commit111c1cb

committed

Removing the use ofModuleWithProviders

1 parent84c4189 commit111c1cbCopy full SHA for 111c1cb

File tree

-21

lines changed

-21

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -173,7 +173,7 @@ If you wish to optimize loading `plotly.js` in a different way, please check bot
`173`	`173`
`174`	`174`	`###Plotly Via CDN Module`
`175`	`175`
`176`		-If you want to load`plotly.js`[from a CDN](https://github.com/plotly/plotly.js#use-the-plotlyjs-cdn-hosted-by-fastly), use the`PlotlyViaCDNModule` andcall`forRoot` method withthe version you want to use:
	`176`	+If you want to load`plotly.js`[from a CDN](https://github.com/plotly/plotly.js#use-the-plotlyjs-cdn-hosted-by-fastly), use the`PlotlyViaCDNModule` andset on the`PlotlyViaCDNModule.plotlyVersion` propertythe plotly.js's version you want to use:
`177`	`177`
`178`	`178`	```typescript
`179`	`179`	`import {NgModule }from'@angular/core';`

Lines changed: 4 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import{NgModule,ModuleWithProviders}from'@angular/core';`
	`1`	`+import{NgModule}from'@angular/core';`
`2`	`2`	`import{CommonModule}from'@angular/common';`
`3`	`3`
`4`	`4`	`import{PlotComponent}from'../shared/plot/plot.component';`
`@@ -51,18 +51,8 @@ export class PlotlyViaCDNModule {`
`51`	`51`	`fn();`
`52`	`52`	`}`
`53`	`53`
`54`		`-staticforRoot(config:Partial<{version:string}>):ModuleWithProviders<PlotlyViaCDNModule>{`
`55`		`-if(config.version===undefined){`
`56`		-console.warn(`It's strongly recommended that you set a plotly version when using via CDN.`);
`57`		`-config.version='latest';`
`58`		`-}`
`59`		`-`
`60`		`-PlotlyViaCDNModule.setPlotlyVersion(config.version);`
`61`		`-PlotlyViaCDNModule.loadViaCDN();`
`62`		`-`
`63`		`-return{`
`64`		`-ngModule:PlotlyViaCDNModule,`
`65`		`-providers:[PlotlyService]`
`66`		`-};`
	`54`	`+staticforRoot(config:Partial<{version:string}>):never{`
	`55`	`+consturl="https://github.com/plotly/angular-plotly.js#customizing-the-plotlyjs-bundle";`
	`56`	+thrownewError(`[PlotlyViaCDNModule] forRoot method is deprecated. Please see:${url}`);
`67`	`57`	`}`
`68`	`58`	`}`

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import{NgModule,ModuleWithProviders}from'@angular/core';`
	`1`	`+import{NgModule}from'@angular/core';`
`2`	`2`	`import{CommonModule}from'@angular/common';`
`3`	`3`
`4`	`4`	`import{PlotComponent}from'../shared/plot/plot.component';`
`@@ -22,10 +22,8 @@ export class PlotlyViaWindowModule {`
`22`	`22`	`PlotlyService.setPlotly(plotly);`
`23`	`23`	`}`
`24`	`24`
`25`		`-staticforRoot():ModuleWithProviders{`
`26`		`-return{`
`27`		`-ngModule:PlotlyViaWindowModule,`
`28`		`-providers:[PlotlyService]`
`29`		`-};`
	`25`	`+staticforRoot():never{`
	`26`	`+consturl="https://github.com/plotly/angular-plotly.js#plotly-via-window-module";`
	`27`	+thrownewError(`[PlotlyViaWindowModule] forRoot method is deprecated. Please see:${url}`);
`30`	`28`	`}`
`31`	`29`	`}`

Comments

(0)