- Notifications
You must be signed in to change notification settings - Fork1.5k
Open
Labels
Milestone
Description
Improvement description
Improve repository class to allow paging and filtering, necessary for studio. Related:https://github.com/pimcore/copilot-bundle/pull/696
E.g.
pimcore/bundles/GenericExecutionEngineBundle/src/Repository/JobRunRepositoryInterface.php
Line 64 indf14e02
| publicfunctiongetJobRunsByUserId( |
Has
$limit and$offset parameter for paging, which is good. But it doesnt provide a way to apply filters.pimcore/bundles/GenericExecutionEngineBundle/src/Repository/JobRunRepositoryInterface.php
Line 74 indf14e02
| publicfunctiongetRunningJobsByUserId( |
Has
$limit option only, but applies a filter to the state (=running).Additionally, we also need to get thetotalCount not only for the whole table, but also for queries where we apply filters.
pimcore/bundles/GenericExecutionEngineBundle/src/Repository/JobRunRepositoryInterface.php
Line 72 indf14e02
| publicfunctiongetTotalCount():int; |