NotificationsYou must be signed in to change notification settings
Fork464
Star1.2k

Fixed producer fallback in sandbox mode#282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

ramunasd wants to merge1 commit intophp-amqplib:master

base:master

Choose a base branch

fromramunasd:producer_interface

Open

Fixed producer fallback in sandbox mode#282

ramunasd wants to merge1 commit intophp-amqplib:masterfromramunasd:producer_interface

Conversation

Copy link

Member

ramunasd commentedJun 30, 2015

Fallback lacks method setContentType

added method setContentType to producer interface, fixed fallback pro…

788406e

…ducer

Copy link

Collaborator

videlalvaro commentedJul 5, 2015

The tests are not passing.

Also, wouldn't this break BC?

Copy link

MemberAuthor

ramunasd commentedJul 6, 2015

Travis had temporary issue, now it's passing all tests.
About BC - if someone has written it's own producer that implements ProducerInterface - then yes, it BC.

Copy link

Collaborator

videlalvaro commentedDec 5, 2015

Sorry to comment so late, but I think this method andsetDeliveryMode should be added here as well? Why not have them in the ProducerInterface as well?

Copy link

github-actionsbot commentedMar 16, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.