- Notifications
You must be signed in to change notification settings - Fork1.9k
Changed integers.java constants location and implemented constants in file#237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
SameerM123 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
finished review
| privatestaticfinalBigDecimalZERO =newBigDecimal(0); | ||
| privatestaticfinalBigDecimalTWO =newBigDecimal(2); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Constants start from here now
| publicstaticfinalStringtoBinaryUsingDivideAndModulus(intnumberToConvert) { | ||
| intinteger =numberToConvert; | ||
| if (integer<0)thrownewIllegalArgumentException("Method argument cannot be negative. number="+integer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Rest of code is formatting issues that bothered me when trying to implement the constants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As well as implementing constants obviously
Changed integers.java constants location and implemented constants in file, according to assignment instructions