Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Splitting the core.phel#160

Locked
Chemaclass started this conversation inIdeas
Jan 9, 2021· 4 comments· 4 replies
Discussion options

What do you think about grouping and splitting thecore.phel into multiple files?

I am not sure right now about how exactly, but I while reading thecore.phel I realise that this grouping is done somehow by the comment delimiters such as:

# ----------------# Print operations# ----------------

These are all of them:

  • Basic methods for quasiquote and destructure
  • Basic macros
  • Basic constructors
  • Basic sequence operations
  • Boolean operation
  • Control structure macros
  • Type operation
  • Sequence operation
  • Sequence functions
  • Set operation
  • Function operation
  • More Sequence operation
  • Bitwise operation
  • Math operation
  • Print operations
  • Threading macros

There are 16 of them. It makes sense to think about splitting them, same as we already did for thehttp.phel,html.phel andtest.phel.

As an idea, maybe we could keep all basics stuff in the "core", and try to group the rest on their own files?
I am not so keen on having 16 different files and that you need to require all of them everywhere because you will likely use every function... On the other hand, I like the idea that you will require the files that you really need, so you don't waste performance "requiring and parsing" stuff that you don't really need. And not only performance, but you will also group every function within their context, so the maintainability of each file will be easier in my opinion.

What do you think?

You must be logged in to vote

Replies: 4 comments 4 replies

Comment options

I will have a look if there is a way to split the files but keep them under the same namespace. Then we have both advantages.

You must be logged in to vote
1 reply
@Chemaclass
Comment options

ChemaclassJan 9, 2021
Maintainer Author

yes, I think that's possible and we can do it out of the box. Let's try this first and see how it was 👍🏼

Comment options

I created an issue for that#169

You must be logged in to vote
0 replies
Comment options

@Chemaclass@jenshaase can we close this?

You must be logged in to vote
3 replies
@jenshaase
Comment options

This is a discussion. Can we close a discussion?

@Chemaclass
Comment options

ChemaclassFeb 3, 2021
Maintainer Author

I locked it... I don't find any "close" action for a discussion 😂

@JesusValeraDev
Comment options

No idea 😆

Comment options

Chemaclass
Oct 22, 2022
Maintainer Author

This was done (#169) but undone later when working on the compile command (#293). So I will mark this aswontdo.

You must be logged in to vote
0 replies
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Category
Ideas
Labels
wontdoThis will not be worked on
3 participants
@Chemaclass@jenshaase@JesusValeraDev

[8]ページ先頭

©2009-2025 Movatter.jp