- Notifications
You must be signed in to change notification settings - Fork3.2k
feat: improve type safety for siblingData in field types#14895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
feat: improve type safety for siblingData in field types#14895
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| }from'../validations.js' | ||
| exporttypeFieldHookArgs<TDataextendsTypeWithID=any,TValue=any,TSiblingData=any>={ | ||
| exporttypeFieldHookArgs<TDataextendsTypeWithID=any,TValue=any,TSiblingData=TData>={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TData !== TSiblingData if you're in a group field. I'd rather have it typed weakly (any) than potentially incorrectly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i see the issue, pls check my new commit
Rollback TSiblingData generic parameter default from `TData` to `any` across FieldHookArgs, FieldHook, FieldAccessArgs, FieldAccess, Condition, and FilterOptionsProps types. This allows siblingData to have a different type than the top-level document data, improving type flexibility for nested field structures.Add TSiblingData type to FilterOptionsProps
Summary
Improves TypeScript type safety for
siblingDataacross field configuration types by introducing a StripRelationships utility type that removes populated relationship objects, keeping the ID type (numberorstring) base on database config.