- Notifications
You must be signed in to change notification settings - Fork47
Add option to reverse aggregate fields#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Peter-McLean-Altera wants to merge3 commits intop-ranav:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Add option to reverse aggregate fields#34
Peter-McLean-Altera wants to merge3 commits intop-ranav:masterfromPeter-McLean-Altera:feature/reverse_aggregate_fields
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intended use case for this feature is serializing data structures to a binary format compatible with SystemVerilog struct. In SystemVerilog, the last field in the struct is actually at the lowest address and the first field is in the highest address. By adding an option to reverse field serialization order, it's possible to interchange binary data with SystemVerilog when all struct members have the same byte alignment.
I did not add reorder to any aggregate type_info functions. As they are used now, I don't think it will change any functionality. Users of reverse_aggregate_fields would have to understand the binary compatibility issues
Please excuse the whitespace trimming in README.md.
Draft until tests added.