- Notifications
You must be signed in to change notification settings - Fork1.7k
Don't spray XML parser errors to stderr#2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
erkia wants to merge1 commit intoowasp-modsecurity:v2/masterChoose a base branch
base:v2/master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
martinhsv commentedOct 17, 2023
Hello@erkia , Could you provide a couple of examples of such messages? Ideally include xml bodies to reproduce them and whether any special configuration is required to reproduce the issue (e.g. higher LogLevel in the apache config). |
marcstern commentedFeb 1, 2024
Non-standard messages in error log are not clean, but no message at all isn't good either. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all XML parser errors are written to stderr, which in case of Apache means that the messages end up randomly in error_log, unformatted.
This pull request adds custom XML error handling function, which just discards all the messages at the moment.