Commit7ebca53

authored

Merge pull requestsigmavirus24#632 from itsmemattchung/issue/627

Raise exception for instance_or_null

2 parents008cb11 +1322fc8 commit7ebca53Copy full SHA for 7ebca53

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ def _instance_or_null(self, instance_class, json):`
`143`	`143`	`ifjsonisNone:`
`144`	`144`	`returnNullObject(instance_class.__name__)`
`145`	`145`	`ifnotisinstance(json,dict):`
`146`		`-returnexceptions.UnprocessableResponseBody(`
	`146`	`+raiseexceptions.UnprocessableResponseBody(`
`147`	`147`	`"GitHub's API returned a body that could not be handled",json`
`148`	`148`	`)`
`149`	`149`	`try:`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,11 @@ def test_from_json(self):`
`107`	`107`	`github_core=GitHubCore.from_json('{}')`
`108`	`108`	`assertisinstance(github_core,GitHubCore)`
`109`	`109`
	`110`	`+deftest_instance_or_null(self):`
	`111`	`+"""Verify method raises exception when json is not a dict."""`
	`112`	`+withpytest.raises(exceptions.UnprocessableResponseBody):`
	`113`	`+self.instance._instance_or_null(GitHubCore, [])`
	`114`	`+`
`110`	`115`	`deftest_json(self):`
`111`	`116`	`"""Verify JSON information is retrieved correctly."""`
`112`	`117`	`response=requests.Response()`

Comments

(0)