- Notifications
You must be signed in to change notification settings - Fork45
feat: View images in a modal screen from rich text editor#3425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge4 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: shiroyasha <1779493+shiroyasha@users.noreply.github.com>
Co-authored-by: shiroyasha <1779493+shiroyasha@users.noreply.github.com>
CopilotAI changed the title[WIP] View images in a modal screenfeat: View images in a modal screen from rich text editorSep 15, 2025
Copilot finished work on behalf ofshiroyashaSeptember 15, 2025 14:53
Signed-off-by: Igor Šarčević <igor@operately.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR implements the ability to view images in a modal overlay when clicked from rich text areas, replacing the previous behavior where clicking an image would open it in a new tab.
Changes
New Modal Experience
Updated Actions
Implementation Details
New Component:
ImageModal(app/assets/js/components/ImageModal/index.tsx)Modified Component: Updated
ImageViewinBlobView.tsxTests: Added comprehensive tests for the ImageModal component covering open/close states and link behaviors.
Visual Demo
Before and After Comparison:
Modal in Action:
User Experience Impact
This change addresses the issue where clicking the image and "View" performed the same action, providing a more intuitive and contextual image viewing experience within the rich text editor.
Fixes#656.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
127.0.0.11If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.