We have infinite loop and on certain condition, we exit this loop and thread with pthread_exit(). But also after this loop, we have a code to perform pthread_cleanup_pop() and return from the thread.

The problem is that modern compilers are able to recognize that we actually never get to the statements after loop and therefore it is dead code there.

I think, instead of pthread_exit(), it is better to break out of loop and let the last statements to work as intended. This is because we do need to keep pthread_cleanup_pop() anyhow. Of course, it is matter of taste if we want to use return or pthread_exit as very last statement in this function.

Note, since pthread_exit() will call the registered functions by pthread_cleanup_push(), we do not change any of the semantics there.

Motivation and Context

clear warning about unreachable code and, I think, it is good to have a bit more readable code.

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• [ x] Code cleanup (non-breaking change which makes code smaller or more readable)
• [ x] Quality assurance (non-breaking change which makes the code more robust against bugs)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFScode style requirements.
• I have updated the documentation accordingly.
• I have read thecontributing document.
• I have addedtests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and containSigned-off-by.