Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] Gromacs apply_restraints (+ basic mdp parsing)#971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hejung wants to merge2 commits intoopenpathsampling:master
base:master
Choose a base branch
Loading
fromhejung:gromacs_apply_restraints

Conversation

@hejung
Copy link
Contributor

This is based on our discussion in#889 .

It adds:

  • parsing of gromacs mdp files (including types for most/all options we would want to use/modify from ops)
  • snapshot_timstep property (in ps) as calculated from the parsed mdp
  • write_mdp method for gromacs engine to write (modified) mdp files
  • apply_restraints method for gromacs engine
  • randomize_velocities method for gromacs engine (I would add this here since it feels natural to me to do it in one go with thewrite_mdp andapply_restraints)

Some things to note:

  • I went with lists as values for every gromacs mdp option. This is due to the fact that gromacs allows multiple values for most mdp options. I did not treat the options which only have one value ('dt', 'nstxout', etc.) specially, this will also make thewrite_mdp method much simpler.

…ld want to use from ops + for many more. Also adds support for reading and automatically setting the snapshot_timestep from the values of 'nstxout' and 'dt' from the mdp file.
@codecov
Copy link

codecovbot commentedFeb 1, 2021
edited
Loading

Codecov Report

Merging#971 (3c8ee74) intomaster (767d358) willincrease coverage by0.05%.
The diff coverage is93.22%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #971      +/-   ##==========================================+ Coverage   80.25%   80.30%   +0.05%==========================================  Files         136      136                Lines       14449    14507      +58     ==========================================+ Hits        11596    11650      +54- Misses       2853     2857       +4
Impacted FilesCoverage Δ
openpathsampling/engines/gromacs/engine.py94.85% <93.22%> (-0.66%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update767d358...971d38b. Read thecomment docs.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hejung@dwhswenson

[8]ページ先頭

©2009-2025 Movatter.jp