- Notifications
You must be signed in to change notification settings - Fork49
[WIP] OpenMMToolsMCEngine#1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedJul 28, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1041 +/- ##==========================================+ Coverage 81.54% 81.63% +0.09%========================================== Files 140 141 +1 Lines 15400 15509 +109 ==========================================+ Hits 12558 12661 +103- Misses 2842 2848 +6
Continue to review full report at Codecov.
|
I seem to have a problem when I hit max length errors, though
At this point, this seems to work. However, sampling single-atom Cartesian displacements, even for alanine dipeptide in vacuum, isSLOW. I think I need to improve the premise of the example before it is useful pedagogically without the context of this PR and#1040. Performance is also not great. I haven't profiled it yet, but I wonder if we're going to and from the GPU with each MC trial. It looks to me like the OpenMMTools MCMC stuff was designed with hybrid Monte Carlo in mind, where one proposal creation would involve a significant chunk of work on the GPU. Right now, I can't get an equilibrated trajectory because (1) trajectories are very long because single atom displacements require many frames for a transition; and (2) each frame seems to be quite slow compared to MD. (And of course (3) I need my computer for other things!) |
Uh oh!
There was an error while loading.Please reload this page.
This provides an engine that wraps the tools in
openmmtools.mcmc. This will allow users to perform path sampling simulations of Monte Carlo "trajectories."MCSampler(don't requiredWeightedMove)