Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] OpenMMToolsMCEngine#1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dwhswenson wants to merge12 commits intoopenpathsampling:master
base:master
Choose a base branch
Loading
fromdwhswenson:openmmtools_mc_engine

Conversation

@dwhswenson
Copy link
Member

@dwhswensondwhswenson commentedJul 28, 2021
edited
Loading

This provides an engine that wraps the tools inopenmmtools.mcmc. This will allow users to perform path sampling simulations of Monte Carlo "trajectories."

  • Basic dynamics
  • Serialization
  • Support for MDTraj
  • Allow same input options asMCSampler (don't requiredWeightedMove)
  • Docstrings
  • Example
  • Tests

@dwhswensondwhswenson marked this pull request as draftJuly 28, 2021 21:38
@codecov
Copy link

codecovbot commentedJul 28, 2021
edited
Loading

Codecov Report

Merging#1041 (e94fb60) intomaster (c67edf7) willincrease coverage by0.09%.
The diff coverage is90.90%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1041      +/-   ##==========================================+ Coverage   81.54%   81.63%   +0.09%==========================================  Files         140      141       +1       Lines       15400    15509     +109     ==========================================+ Hits        12558    12661     +103- Misses       2842     2848       +6
Impacted FilesCoverage Δ
openpathsampling/engines/openmm/mcengine.py90.90% <90.90%> (ø)
...enpathsampling/analysis/shooting_point_analysis.py98.66% <0.00%> (+0.21%)⬆️
openpathsampling/engines/dynamics_engine.py80.91% <0.00%> (+0.76%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec67edf7...e94fb60. Read thecomment docs.

@dwhswenson
Copy link
MemberAuthor

At this point, this seems to work. However, sampling single-atom Cartesian displacements, even for alanine dipeptide in vacuum, isSLOW. I think I need to improve the premise of the example before it is useful pedagogically without the context of this PR and#1040.

Performance is also not great. I haven't profiled it yet, but I wonder if we're going to and from the GPU with each MC trial. It looks to me like the OpenMMTools MCMC stuff was designed with hybrid Monte Carlo in mind, where one proposal creation would involve a significant chunk of work on the GPU.

Right now, I can't get an equilibrated trajectory because (1) trajectories are very long because single atom displacements require many frames for a transition; and (2) each frame seems to be quite slow compared to MD. (And of course (3) I need my computer for other things!)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dwhswenson

[8]ページ先頭

©2009-2025 Movatter.jp