- Notifications
You must be signed in to change notification settings - Fork5.9k
Updated version of main README#3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:4.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
formatting update
Added a line next to end to separate the two instructions, the last one is for addition of new module ones.
opencv-alalek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We don't accept PRs with massive "changes for changes" without significant "added value".
| As the result, OpenCV will be built in the`<opencv_build_directory>` with all | ||
| modules from`opencv_contrib` repository. If you don't want all of the modules, | ||
| use CMake's`BUILD_opencv_*`options. Like in this example: | ||
| use CMake's`BUILD_opencv_*`option where * is the given name of a module as <reponame> in this example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
reponame
This is not accurate. This just confuses user.<module> should be used instead.
ronaldoscFeb 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, you're correct. The name of repo consists in the same name's module, right?
Can you suggest more clear text explanation for this line ?
| $make -j5 | ||
| ```bash | ||
| cd<opencv_build_directory> | ||
| cmake -D OPENCV_EXTRA_MODULES_PATH=<opencv_contrib>/modules<opencv_source_directory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not a mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know that. But for the best practices and DX the -D separated is more readable.
This PR is a correction in some commands in main documentation.
Were edited the commands for bash for default and deleted the "$" for best copy & paste.